Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of tests for dlqMessageHandler in common domain #5969

Merged
merged 20 commits into from
Jun 4, 2024
Merged

Addition of tests for dlqMessageHandler in common domain #5969

merged 20 commits into from
Jun 4, 2024

Conversation

abhishekj720
Copy link
Contributor

@abhishekj720 abhishekj720 commented May 6, 2024 •
edited
Loading

What changed?
Added test for start, stop, merge and emitDLQSize in dlqMessageHandler

Why?
As part of test coverage week

How did you test it?
Unit tests

Potential risks
No risks, as these are unit tests

Release notes

Documentation Changes

@codecov Codecov
Copy link

codecov bot commented May 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.12%. Comparing base (17a7ba7) to head (f8318c1).
Report is 102 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
common/domain/dlq_message_handler.go 96.19% <100.00%> (ø)
service/frontend/admin/handler.go 57.60% <100.00%> (+10.15%) ⬆️

... and 134 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a7ba7...f8318c1. Read the comment docs.

taylanisikdemir
taylanisikdemir reviewed May 6, 2024
View reviewed changes
common/domain/dlqMessageHandler_test.go Outdated Show resolved Hide resolved
common/domain/dlqMessageHandler_test.go Outdated Show resolved Hide resolved
common/domain/dlqMessageHandler_test.go Outdated Show resolved Hide resolved
abhishekj720 and others added 9 commits May 6, 2024 14:05
@abhishekj720
stopped when dlqmessageHandler has been started
513e789
@abhishekj720
Test for DLQ message Handler
5e67962
@taylanisikdemir @abhishekj720
Replace wurstmeister kafka/zookeeper images with bitnami kafka image (u…
a5d3bcb 
…ber#5975)
@taylanisikdemir @abhishekj720
Split historyEngine.go into small files (uber#5972)
7f82bb5
@timl3136 @abhishekj720
Added unit tests for service/history/handler (uber#5970)
fd3dc8e 
* Added unit tests for history handler
@Shaddoll @abhishekj720
Add unit tests for mutable state task refresher (uber#5971)
dfd0f00
@taylanisikdemir @abhishekj720
Revert codecov patch threshold to 85% (uber#5982)
60d84b6
@ibarrajo @abhishekj720
Api handler test respond activity task failed alternate (uber#5980)
175a155 
* TestRespondActivityTaskFailed_Success implementation

* Alternate test for TerstRespondActivityTaskFailed

* code lint
@natemort @abhishekj720
Move shardscanner workflow tests to the shardscanner package (uber#5981)
c664051 
This ensures they get included in the code coverage metrics.
@coveralls
Copy link

coveralls commented May 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 018fe4c1-d5d9-4c74-b7a7-acd930882617

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 62 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.003%) to 68.415%
Files with Coverage Reduction New Missed Lines %
common/persistence/sql/sqlplugin/postgres/task.go 2 73.4%
service/history/handler/handler.go 2 60.71%
service/matching/db.go 2 73.23%
service/history/task/transfer_active_task_executor.go 2 73.03%
common/util.go 2 91.78%
service/matching/matcher.go 2 90.72%
common/log/tag/tags.go 3 50.46%
common/task/fifo_task_scheduler.go 3 84.54%
service/history/task/timer_standby_task_executor.go 3 85.63%
service/history/queue/timer_queue_processor_base.go 3 77.87%
Totals Coverage Status
Change from base Build 018f54e5-7508-40f1-ae99-a0884c40b0fa: 0.003%
Covered Lines: 100489
Relevant Lines: 146882
💛 - Coveralls

@abhishekj720 abhishekj720 merged commit f130035 into uber:master Jun 4, 2024
20 checks passed
@abhishekj720 abhishekj720 deleted the testc-2 branch June 4, 2024 20:11
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
@abhishekj720 @timl3136
Addition of tests for dlqMessageHandler in common domain (uber#5969)
f859b69
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 4, 2024
@abhishekj720 @timl3136
Addition of tests for dlqMessageHandler in common domain (uber#5969)
a9cccf3
dkrotx pushed a commit to dkrotx/cadence that referenced this pull request Jun 5, 2024
@abhishekj720 @dkrotx
Addition of tests for dlqMessageHandler in common domain (uber#5969)
b61e9ba
timl3136 pushed a commit to timl3136/cadence that referenced this pull request Jun 6, 2024
@abhishekj720 @timl3136
Addition of tests for dlqMessageHandler in common domain (uber#5969)
cee8992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Groxx Groxx Groxx left review comments

@taylanisikdemir taylanisikdemir taylanisikdemir left review comments

@agautam478 agautam478 agautam478 approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@abhishekj720 @coveralls @Groxx @taylanisikdemir @davidporter-id-au @agautam478 @timl3136 @Shaddoll @ibarrajo @natemort