Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estimate_ate in Xlearner triggers a retrain of the model when pretrain=True and external propensity scores are used #596

Closed
AlxClt opened this issue Jan 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@AlxClt
Copy link
Contributor

AlxClt commented Jan 17, 2023

Describe the bug
When calling BaseXlearner.estimate_ate() with pretrain=True and external propensity scores (i.e. p is not None), a retrain of the model is triggered because the case where pretrain=True and p is not None is not handled

To Reproduce
Train the Xlearner with externally computed propensity scores and call estimate_ate using pretrain=True and external propensity scores. The model will be retrained.

Expected behavior
The model should not be retrained, instead the ate should be computed using the passed propensity scores

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • Windows
  • Python Version: 3.8.10
  • pandas==1.2.4, scikit-learn==1.2.0, cython==0.29.23

Additional context
Add any other context about the problem here.

@AlxClt AlxClt added the bug Something isn't working label Jan 17, 2023
@AlxClt
Copy link
Contributor Author

AlxClt commented Jan 17, 2023

Fix should be very simple, working on it

AlxClt added a commit to AlxClt/causalml that referenced this issue Jan 17, 2023
…es in estimate_ate without triggering a retrain of the model."
AlxClt added a commit to AlxClt/causalml that referenced this issue Jan 17, 2023
AlxClt added a commit to AlxClt/causalml that referenced this issue Jan 17, 2023
…es in estimate_ate without triggering a retraining of the model."
@AlxClt
Copy link
Contributor Author

AlxClt commented Jan 17, 2023

Fix in PR #597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant