Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #596 #597

Merged
merged 4 commits into from
Feb 3, 2023
Merged

Fix #596 #597

merged 4 commits into from
Feb 3, 2023

Conversation

AlxClt
Copy link
Contributor

@AlxClt AlxClt commented Jan 17, 2023

Proposed changes

Adding the case when pretrain=True and p is not None in BaseXLearner.estimate_ate

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • [x ] I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

This is a very simple fix - should not require additional tests

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching it and fixing it.

@jeongyoonlee
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

acollette seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AlxClt, can you sign the CLA?

@jeongyoonlee jeongyoonlee added the bug Something isn't working label Jan 20, 2023
@AlxClt
Copy link
Contributor Author

AlxClt commented Feb 2, 2023

@jeongyoonlee , just signed the CLA, thanks for pointing this out!

@jeongyoonlee jeongyoonlee merged commit 13ae257 into uber:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants