add BaseLearner() so that other meta learners inherit from it #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongyoonlee
requested review from
paullo0106,
huigangchen,
ppstacy,
t-tte and
yluogit
|
|
jeongyoonlee
force-pushed
the
jeong/refactoring_meta_learners
branch
from
125fe47
to
6bd5a49
Compare
jeongyoonlee
force-pushed
the
jeong/refactoring_meta_learners
branch
from
6bd5a49
to
4708da2
Compare
ppstacy
reviewed
Feb 2, 2021
causalml/inference/nn/cevae.py
Outdated
| pyro_logger = logging.getLogger("pyro") | ||
| pyro_logger.setLevel(logging.DEBUG) | ||
| if pyro_logger.handlers: | ||
| pyro_logger.handlers[0].setLevel(logging.DEBUG) | ||
|
|
||
|
|
||
| class CEVAE(object): |
There was a problem hiding this comment.
Should we inherit the BaseLearner here?
There was a problem hiding this comment.
We can't because currently CEVAE and DragonNet don't have estimate_ate(). I will remove it from DragonNet as well.
10 tasks
lee-junseok
added a commit
to lee-junseok/causalml
that referenced
this pull request
Apr 12, 2024
jeongyoonlee
pushed a commit
that referenced
this pull request
Apr 12, 2024
* 757: add return_ci=True in sensitivity * remove if-else logic - resolved in #295 * black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes #294. It adds the
BaseLearnerclass with the bootstrapping and interpretability functions so that other meta-learners inherit them from it without duplicated code.Types of changes
What types of changes does your code introduce to CausalML?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
N/A