address comments

visgl · Apr 5, 2019 · 50c22a2 · 50c22a2
1 parent 4963570
commit 50c22a2
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 17 deletions.
diff --git a/examples/get-started/pure-js-google-maps/app.js b/examples/get-started/pure-js-google-maps/app.js
@@ -6,10 +6,9 @@ import {GeoJsonLayer} from '@deck.gl/layers';
 const GEOJSON =
   'https://d2ad6b4ur7yvpq.cloudfront.net/naturalearth-3.3.0/ne_110m_admin_1_states_provinces_shp.geojson'; //eslint-disable-line
 
-// Retrieving GOOGLE_MAPS_API_KEY from the environment variable
-const gmUrl = `https://maps.googleapis.com/maps/api/js?key=${
-  process.env.GOOGLE_MAPS_API_KEY // eslint-disable-line
-}&libraries=visualization&v=3.34`;
+// Set your Google Maps API key here or via environment variable
+const GOOGLE_MAPS_API_KEY = process.env.GoogleMapsAPIKey; // eslint-disable-line
+const GOOGLE_MAPS_API_URL = `https://maps.googleapis.com/maps/api/js?key=${GOOGLE_MAPS_API_KEY}&libraries=visualization&v=3.34`;
 
 function loadScript(url) {
   const script = document.createElement('script');
@@ -22,7 +21,7 @@ function loadScript(url) {
   });
 }
 
-loadScript(gmUrl).then(() => {
+loadScript(GOOGLE_MAPS_API_URL).then(() => {
   const map = new google.maps.Map(document.getElementById('map'), {
     center: {lat: 40, lng: -100},
     zoom: 4

diff --git a/examples/get-started/pure-js-google-maps/webpack.config.js b/examples/get-started/pure-js-google-maps/webpack.config.js
@@ -1,20 +1,18 @@
 // NOTE: To use this example standalone (e.g. outside of deck.gl repo)
 // delete the local development overrides at the bottom of this file
 
-// avoid destructuring for older Node version support
-const resolve = require('path').resolve;
 const webpack = require('webpack');
 
 const CONFIG = {
   mode: 'development',
 
   entry: {
-    app: resolve('./app.js')
+    app: './app.js'
   },
 
   plugins: [
     // Read google maps token from environment variable
-    new webpack.EnvironmentPlugin(['GOOGLE_MAPS_API_KEY'])
+    new webpack.EnvironmentPlugin(['GoogleMapsAPIKey'])
   ]
 };
 

diff --git a/examples/get-started/pure-js-mapbox/webpack.config.js b/examples/get-started/pure-js-mapbox/webpack.config.js
@@ -1,15 +1,14 @@
 // NOTE: To use this example standalone (e.g. outside of deck.gl repo)
 // delete the local development overrides at the bottom of this file
 
-// avoid destructuring for older Node version support
-const resolve = require('path').resolve;
+const {resolve} = require('path');
 const webpack = require('webpack');
 
 const CONFIG = {
   mode: 'development',
 
   entry: {
-    app: resolve('./app.js')
+    app: './app.js'
   },
 
   resolve: {

diff --git a/examples/get-started/pure-js/app.js b/examples/get-started/pure-js/app.js
@@ -25,8 +25,8 @@ export const deck = new Deck({
       filled: true,
       lineWidthMinPixels: 2,
       opacity: 0.4,
-      getLineColor: () => [255, 100, 100],
-      getFillColor: () => [200, 160, 0, 180]
+      getLineColor: [255, 100, 100],
+      getFillColor: [200, 160, 0, 180]
     })
   ]
 });

diff --git a/examples/get-started/pure-js/webpack.config.js b/examples/get-started/pure-js/webpack.config.js
@@ -1,15 +1,13 @@
 // NOTE: To use this example standalone (e.g. outside of deck.gl repo)
 // delete the local development overrides at the bottom of this file
 
-// avoid destructuring for older Node version support
-const resolve = require('path').resolve;
 const HtmlWebpackPlugin = require('html-webpack-plugin');
 
 const CONFIG = {
   mode: 'development',
 
   entry: {
-    app: resolve('./app.js')
+    app: './app.js'
   },
 
   plugins: [new HtmlWebpackPlugin({title: 'deck.gl example'})]