Add redraw method #2878
Merged
Add redraw method #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsherif
approved these changes
Apr 2, 2019
| const redrawReason = this.needsRedraw({clearRedrawFlags: true}); | ||
|
|
||
| if (!redrawReason) { | ||
| return; |
There was a problem hiding this comment.
Maybe provide the option to skip the check (e.g. a force argument that defaults to false)? I can imagine scenarios where that would be useful.
ibgreen
reviewed
Apr 2, 2019
|
|
||
| Attempt to draw immediately, rather than waiting for the next draw cycle. By default, deck flushes all changes to the canvas on each animation frame. This behavior might cause the deck canvas to fall out of sync with other components if synchronous updates are required. | ||
|
|
||
| Redrawing frequently outside of rAF may cause performance problems. Only use this method if the render cycle must be managed manually. |
There was a problem hiding this comment.
rAF sounds like something that people may not understand on first read maybe type it out or add some link or extra paragraph?
| this._drawLayers(redrawReason); | ||
| } | ||
| // Redraw if necessary | ||
| this.redraw(false); |
There was a problem hiding this comment.
Just a nit: My concerns about boolean parameters are already well know so I was planning to keep my peace, but I couldn't help but notice that we already felt the need to add a comment explaining what the false parameter means, and this is not even in application code, but in the very same file as the function definition....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For google maps integration