Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H3HexagonLayer: fix render bug cross the 180th meridian #3133

Merged
merged 2 commits into from
May 23, 2019
Merged

H3HexagonLayer: fix render bug cross the 180th meridian #3133

merged 2 commits into from
May 23, 2019

Conversation

Pessimistress
Copy link
Collaborator

Before
image

After
image

@coveralls
Copy link

coveralls commented May 22, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 62.025% when pulling 5f67eeb on x/h3-hexagon-dateline into 54df676 on master.

xintongxia
xintongxia approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@xintongxia xintongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a render test?

@Pessimistress Pessimistress merged commit c7f9c02 into master May 23, 2019
@Pessimistress Pessimistress deleted the x/h3-hexagon-dateline branch May 23, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xintongxia xintongxia xintongxia approved these changes

@nrabinowitz nrabinowitz Awaiting requested review from nrabinowitz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @xintongxia