Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json module bug fixes #3253

Merged
merged 2 commits into from
Jun 20, 2019
Merged

json module bug fixes #3253

merged 2 commits into from
Jun 20, 2019

Conversation

Pessimistress
Copy link
Collaborator

Change List

  • Fix JSONLayer handling of data string
  • Fix bug in csv parsing where all non-numerical values are converted to 0
  • Tests

@coveralls
Copy link

coveralls commented Jun 19, 2019 •
edited
Loading

Coverage Status

Coverage increased (+2.09%) to 78.606% when pulling d8aa50d on x/json-coverage into 67cdd2f on master.

ibgreen
ibgreen approved these changes Jun 19, 2019
View reviewed changes
modules/json/src/json-layer/json-layer.js Outdated Show resolved Hide resolved
@Pessimistress Pessimistress merged commit b89703d into master Jun 20, 2019
@Pessimistress Pessimistress deleted the x/json-coverage branch June 20, 2019 00:15
Pessimistress added a commit that referenced this pull request Jun 20, 2019
@Pessimistress
json module bug fixes (#3253)
03fe553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @ibgreen