Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up LayerManager #4011

Merged
merged 1 commit into from Dec 13, 2019
Merged

Clean up LayerManager #4011

merged 1 commit into from Dec 13, 2019

Conversation

Pessimistress
Copy link
Collaborator

Before

├─ initialize layers - composite: 5.77 iterations/s ±8.85%
├─ update layers - composite: 15.3 iterations/s ±2.17%

After

├─ initialize layers - composite: 6.17 iterations/s ±11.48%
├─ update layers - composite: 17.8 iterations/s ±3.00%

Change List

  • Use flat arguments in recursive private methods
  • Avoid unnecessary small object/string creation in loops
  • Fix an issue where layer finalization is blocked by error

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 83.111% when pulling 5cb03cc on x/layer-manager-perf into 742cff9 on master.

@Pessimistress Pessimistress merged commit 8097852 into master Dec 13, 2019
@Pessimistress Pessimistress deleted the x/layer-manager-perf branch December 13, 2019 17:42
tgorkin added a commit that referenced this pull request Dec 17, 2019
@tgorkin
Merge commit '515466ce583f1419d2b0199daa31f850d3627bb8' into tgorkin/…
57a7ca7 
…gatsby-examples

* commit '515466ce583f1419d2b0199daa31f850d3627bb8': (76 commits)
  fix website build (#4031)
  Tweak to scenegraph layer fix (#4027)
  Fix s2 layer polygon generation (#4024)
  Smooth edges in scatterplot (#4021)
  pydeck: Update for new @deck.gl/json API and add additional tes… (#4020)
  Fix ScenegraphLayer asset wait (#4025)
  v8.0-beta.1 Changelog (#4022)
  Bump dependency versions in modules, examples and docs (#4015)
  v8.0.0-beta.1
  bump loaders.gl to beta.5 (#4018)
  v8.0 beta
  pydeck: Make a single bundle for use in standalone and Jupyter rendering (#4010)
  Clean up LayerManager (#4011)
  Audit assert usages (#4012)
  React: eventManager listens to all children (#4013)
  Fix plot example labels (#4014)
  Bump loaders.gl to 2.0.0-beta (#4009)
  TextLayer: support background color (#3903)
  v8.0 what's new (#4001)
  Improve createProps perf (#4007)
  ...
chrisgervang pushed a commit that referenced this pull request Jan 31, 2020
@Pessimistress @chrisgervang
Clean up LayerManager (#4011)
db6b742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xintongxia xintongxia xintongxia approved these changes

@1chandu 1chandu Awaiting requested review from 1chandu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pessimistress @coveralls @xintongxia