Fix ScenegraphLayer asset wait #4025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ export async function waitForGLTFAssets(gltfObjects) { | |||
|
|
|||
| gltfObjects.scenes.forEach(scene => { | |||
| scene.traverse(model => { | |||
| Object.values(model.model.program.uniforms).forEach(uniform => { | |||
| Object.values(model.model.uniforms).forEach(uniform => { | |||
There was a problem hiding this comment.
Shall we use getUniforms in case of future changes?
There was a problem hiding this comment.
That's a good idea.
Pessimistress
approved these changes
Dec 16, 2019
tgorkin
added a commit
that referenced
this pull request
Dec 17, 2019
…gatsby-examples * commit '515466ce583f1419d2b0199daa31f850d3627bb8': (76 commits) fix website build (#4031) Tweak to scenegraph layer fix (#4027) Fix s2 layer polygon generation (#4024) Smooth edges in scatterplot (#4021) pydeck: Update for new @deck.gl/json API and add additional tes… (#4020) Fix ScenegraphLayer asset wait (#4025) v8.0-beta.1 Changelog (#4022) Bump dependency versions in modules, examples and docs (#4015) v8.0.0-beta.1 bump loaders.gl to beta.5 (#4018) v8.0 beta pydeck: Make a single bundle for use in standalone and Jupyter rendering (#4010) Clean up LayerManager (#4011) Audit assert usages (#4012) React: eventManager listens to all children (#4013) Fix plot example labels (#4014) Bump loaders.gl to 2.0.0-beta (#4009) TextLayer: support background color (#3903) v8.0 what's new (#4001) Improve createProps perf (#4007) ...
chrisgervang
pushed a commit
that referenced
this pull request
Jan 31, 2020
|
Just a note: The
Thus there should not be a need for a method named Implementing the "atomic" glTF loader was a major effort so it would be nice to see the rewards being reaped in places like this. I suspect this would be a good change as there is a general sense that we want to minimize having to deal with async things when close to the WebGL layer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Program uniforms aren't set until the draw.