Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pydeck: Enforce pydeck notebook deck.gl semver on sdist #4227

Merged
merged 3 commits into from
Feb 12, 2020

Conversation

ajduberstein
Copy link
Collaborator

For #4103

Background

Change List

@coveralls
Copy link

coveralls commented Feb 4, 2020

Coverage Status

Coverage remained the same at 80.866% when pulling d25ecc9 on ajd/locking into 26d9b20 on master.

@Pessimistress
Copy link
Collaborator

If I understand this correctly, it will block the ability to publish beta versions of pydeck that depends on a beta version of deck.gl.

@ajduberstein
Copy link
Collaborator Author

If I understand this correctly, it will block the ability to publish beta versions of pydeck that depends on a beta version of deck.gl.

There's nothing currently enforcing that a particular prerelease of pydeck depends on a prerelease of deck.gl, thought I can add that check. This just simply makes sure that a maintainer is intentional about the deck.gl release paired with pydeck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants