Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GeoJSON multi-geometry highlighting #4426

Merged
merged 3 commits into from
Apr 1, 2020
Merged

Fix GeoJSON multi-geometry highlighting #4426

merged 3 commits into from
Apr 1, 2020

Conversation

Pessimistress
Copy link
Collaborator

@Pessimistress Pessimistress commented Mar 27, 2020 •
edited
Loading

For #4365

Background

The GeoJsonLayer splits paths and polygons in Polygon, MultiLineString and MultiPolygon features into multiple data objects before passing them to the sublayers.

To highlight all paths/polygons in the same source geometry, they must be rendered with the same picking color.

Change List

  • PathLayer picking color when used as a sublayer
  • PolygonLayer picking color when used as a sublayer
  • GeoJsonLayer treatment of highlightedObjectIndex

@Pessimistress Pessimistress changed the title Fix GeoJSON multi-geometry picking Fix GeoJSON multi-geometry highlighting Mar 27, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.7%) to 80.548% when pulling f3097da on x/multi-geometry-picking into 6f4f258 on master.

1chandu
1chandu approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@1chandu 1chandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add unit tests or todo item ?

@Pessimistress Pessimistress merged commit aa87ff5 into master Apr 1, 2020
@Pessimistress Pessimistress deleted the x/multi-geometry-picking branch April 9, 2020 22:58
@yocontra yocontra mentioned this pull request Apr 10, 2020
Open
3 tasks
Pessimistress added a commit that referenced this pull request Apr 26, 2020
@Pessimistress
Fix GeoJSON multi-geometry highlighting (#4426)
4ae30fe
@Pessimistress Pessimistress mentioned this pull request Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusbotella jesusbotella jesusbotella approved these changes

@1chandu 1chandu 1chandu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pessimistress @coveralls @jesusbotella @1chandu