Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Emscripten build in CI #5

Closed
isaacbrodsky opened this issue Jun 19, 2018 · 3 comments
Closed

Test Emscripten build in CI #5

isaacbrodsky opened this issue Jun 19, 2018 · 3 comments

Comments

@isaacbrodsky
Copy link
Collaborator

We should test the Emscripten build in CI and fail if the generated artifact differs from the commit.
@isaacbrodsky isaacbrodsky mentioned this issue Jun 19, 2018
Merged
@nrabinowitz
Copy link
Collaborator

I wonder if there's any way to gate this step by file - e.g. if you change any file in build or out. Otherwise I'm worried about build times, since Travis would have to download Emscripten and clone the core H3 lib to run the build, and it could be slow.

@isaacbrodsky
Copy link
Collaborator Author

You might be able to set Travis CI to cache the Emscripten install: https://docs.travis-ci.com/user/caching/

@isaacbrodsky isaacbrodsky mentioned this issue Jun 26, 2018
Closed
@isaacbrodsky
Copy link
Collaborator Author

Fixed in #14, thanks @nrabinowitz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nrabinowitz @isaacbrodsky