Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to v4.0.0-rc4 #141

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Upgrade to v4.0.0-rc4 #141

merged 2 commits into from
Jul 26, 2022

Conversation

isaacbrodsky
Copy link
Collaborator

@isaacbrodsky isaacbrodsky commented Jul 26, 2022 •
edited
Loading

Primary change here is renaming distance to greatCircleDistance. Did not change anything about version numbers are the previous release candidate upgrade was not released AFAIK.

@coveralls
Copy link

coveralls commented Jul 26, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2741227427

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 2715617492: 0.0%
Covered Lines: 531
Relevant Lines: 531
💛 - Coveralls

@nrabinowitz nrabinowitz merged commit 43be742 into uber:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrabinowitz nrabinowitz nrabinowitz approved these changes

@dfellis dfellis dfellis approved these changes

@ajfriend ajfriend Awaiting requested review from ajfriend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@isaacbrodsky @coveralls @nrabinowitz @dfellis