Fix: Fail pre-publish script if there are uncommitted changes #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrabinowitz
commented
Aug 11, 2022
|
|
||
| ## [4.0.0-rc2] - 2022-08-10 | ||
| ## [4.0.0-rc2] - 2022-08-11 |
There was a problem hiding this comment.
Got optimistic on when the release would go out
Pull Request Test Coverage Report for Build 2841097276
💛 - Coveralls |
dfellis
approved these changes
Aug 11, 2022
isaacbrodsky
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
v4.0.0-rc2release seems to have included WIP changes that weren't intended in the package, due to some inconsistency in my local env. This updates the pre-publish script to fail if there are uncommitted changes after running the distribution build.