Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump core library to 4.1.0, adding cellToChildPos, childPosToCell, and cellToChildrenSize #170

Merged
merged 6 commits into from
Jan 19, 2023

Conversation

nrabinowitz
Copy link
Collaborator

  • Bumps the H3 core library to v4.1.0
  • Adds bindings for cellToChildPos, childPosToCell, and cellToChildrenSize (the last because it's quite useful in iterating through child cells with childPosToCell)
  • Adds tests and benchmarks for the new functions

@coveralls
Copy link

coveralls commented Jan 19, 2023

Pull Request Test Coverage Report for Build 3960919727

  • 26 of 27 (96.3%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 99.548%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/h3core.js 26 27 96.3%
Totals Coverage Status
Change from base Build 3960901929: -0.3%
Covered Lines: 549
Relevant Lines: 550

💛 - Coveralls

@isaacbrodsky
Copy link
Collaborator

We may want to also expose cellToChildrenSize in h3-java

@nrabinowitz
Copy link
Collaborator Author

We may want to also expose cellToChildrenSize in h3-java

I considered renaming it to getMaxChildPos or similar, but I guess it makes sense to stick with the core library name, even though it's named more like a cellToChildren sub-utility than part of the real API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants