Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unhandledRejection handling from emscripten build #64

Merged
merged 1 commit into from
Sep 12, 2019
Merged

Remove unhandledRejection handling from emscripten build #64

merged 1 commit into from
Sep 12, 2019

Conversation

nrabinowitz
Copy link
Collaborator

@nrabinowitz nrabinowitz commented Sep 12, 2019 •
edited
Loading

Upgrades the emscripten docker container to use v1.38.43, which includes support for the NODEJS_CATCH_REJECTION flag, and updates the build to set the flag to 0, removing default unhandledRejection handling.

Fixes #62

@coveralls
Copy link

Pull Request Test Coverage Report for Build 138

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 137: 0.0%
Covered Lines: 362
Relevant Lines: 362
💛 - Coveralls

@nrabinowitz nrabinowitz merged commit 4f81111 into uber:master Sep 12, 2019
@nrabinowitz nrabinowitz deleted the emscripten-unhandledrejection branch September 12, 2019 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogly jogly jogly approved these changes

@isaacbrodsky isaacbrodsky isaacbrodsky approved these changes

@dfellis dfellis Awaiting requested review from dfellis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnhandledRejection
4 participants
@nrabinowitz @coveralls @jogly @isaacbrodsky