Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade core library to 3.6.1 #74

Merged
merged 3 commits into from
Nov 11, 2019
Merged

Conversation

nrabinowitz
Copy link
Collaborator

Fixes edge cases in polyfill and improves polyfill perf in some cases (though not in my current benchmarks).

@coveralls
Copy link

coveralls commented Nov 11, 2019

Pull Request Test Coverage Report for Build 157

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 156: 0.0%
Covered Lines: 724
Relevant Lines: 724

💛 - Coveralls

@dfellis
Copy link
Collaborator

dfellis commented Nov 11, 2019

The performance improvements really appeared for the very large geofences. And according to Isaac seemed to mostly be Clang vs GCC (I compiled in Clang and got the improvements, GCC was equally fast with both) so it could be more compiler-dependent than I would have expected.

@nrabinowitz
Copy link
Collaborator Author

The performance improvements really appeared for the very large geofences. And according to Isaac seemed to mostly be Clang vs GCC (I compiled in Clang and got the improvements, GCC was equally fast with both) so it could be more compiler-dependent than I would have expected.

With my current benchmark on a relatively small polygon, there was no appreciable difference. But since we also get correctness, that's still a good thing :).

@nrabinowitz nrabinowitz merged commit 9e9d891 into uber:master Nov 11, 2019
@nrabinowitz nrabinowitz deleted the upgrade-core branch November 11, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants