-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix h3IsValid false positives on certain invalid strings, bump core library to 3.6.3 #81
Conversation
2f7c35e
to
9eff730
Compare
CHANGELOG.md
Outdated
### Fixed | ||
- Fixed `h3IsValid` returning true on certain edge cases (#81) | ||
### Changed | ||
- Updated the core library to 3.6.3 (#81) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: do we want to mention what was changed in the core library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say unless we come up with a good way to auto-populate that, it's a bunch of make-work and not super valuable (those interested can look at the core library CHANGELOG).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a short note. I think it's worthwhile if the changes are substantive, since most consumers will only look at the binding notes and may not realize they need to look further to understand changes.
Fixes #79
This diff has an appreciable impact on
h3IsValid
benchmarks:master
this branch
However I can't find a more performant approach that fixes the false positives, which stem from
parseInt
ignoring unparsable chars. Open to suggestions. The perf is still very good, obviously, but this could be an issue if consumers need to validate large sets of hexagons.