Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose cython API for external use #234

Merged
merged 13 commits into from
May 13, 2022

Conversation

kylebarron
Copy link
Contributor

@kylebarron kylebarron commented Apr 25, 2022

Change list

  • Update CMakeLists.txt to include .pyx and .pxd files in distribution after skbuild is done processing
  • Include h3api.h in final bundle. This can usually be found automatically when compiling, but if we have issues with this in the future, we can emulate Numpy and its np.get_include function.
  • Add test that uses the external Cython API.

Closes #152

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #234 (d951b5e) into master (3d09da1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #234   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          425       425           
=========================================
  Hits           425       425           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d09da1...d951b5e. Read the comment docs.

@kylebarron kylebarron marked this pull request as ready for review April 26, 2022 21:49
@kylebarron
Copy link
Contributor Author

Ah the test script in cibuildwheel needs to be updated to either ignore the Cython test or compile the cython file used in that test.

@kylebarron
Copy link
Contributor Author

I updated to ignore the test when the cython example wasn't compiled

@ajfriend ajfriend merged commit f59a1ea into uber:master May 13, 2022
@ajfriend
Copy link
Contributor

Sweeeeeeet!

@ajfriend
Copy link
Contributor

Really simple notebook example for future reference: https://gist.github.com/ajfriend/167afffde74bc08b0e809e10b92ecde3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example using cimport h3 in external code for speed
2 participants