Remove deviceAgnostic, agnosticOptions, add new replacement called fileNameOptions #64
Conversation
alanzeino
changed the title
| @@ -151,9 +151,9 @@ | |||
| B31987FF1AB782D100B0A900 /* Tests */, | |||
| B31987F11AB782D000B0A900 /* Products */, | |||
| ); | |||
| indentWidth = 2; | |||
| @@ -95,23 +95,25 @@ - (void)testCompareReferenceImageWithDifferentSizes | |||
| XCTAssertEqual(error.code, FBSnapshotTestControllerErrorCodeImagesDifferentSizes); | |||
| } | |||
|
|
|||
| - (void)testFailedImageWithDeviceAgnosticShouldHaveModelOnName | |||
| - (void)testFailedImageWithFileNameOptionShouldHaveModelOnName | |||
There was a problem hiding this comment.
Can we add three additional tests for other file name options to get code coverage for this method up to 100%?
There was a problem hiding this comment.
Added a test that covers all the file name options with a for loop, and added a test that covers all the file name options in one file name at the same time.
alanzeino
force-pushed
the
options
branch
2 times, most recently
from
dc2523d
to
2160c09
Compare
|
Agree with the OP in #52. I also noted when I first started using this tool that the naming for both the old and new properties was the exact reverse of the correct meaning—so just endorsing this is a good change to make in order to have human-readable properties that make sense. |
|
Is there any way you can provide an example of how to implement the new fileNameOptions update? Thanks in advance |
There's an example in the headerdoc |
We wanted to simply deprecate
agnosticOptionsand addfileNameOptionsin a non–breaking way, but it made the implementation a bit too difficult. So if you're here trying to figure out whereagnosticOptionswent, we renamed it tofileNameOptions. Screen Scale is now part of the file options mask, so if you want to remove screen scale from your file names you can do so.Fixes #30
Fixes #52