Swift library evolution support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update License, Remove Patents file
* Update library to support library test bundles * Delete fb_strictKeyWindow, improve documentation
* Allowing flexible folder names
This improves the support for IMAGE_DIFF_DIR by adding support for setting it as a preprocessor macro, as well as setting it on FBSnapshotTestController. Also refactors how this directory is passed around in the library to make it match how FB_REFERENCE_IMAGE_DIR works.
Swift code using this project has to unnecessarily unwrap return values that are not Optional. Let's improve the portability of this project by annotating all the public API as well as improving the ability to run the static analyzer on this code.
``` $ find . -name *.[hm] | xargs bin/clang-format -i -style=file ```
If you are using this property please migrate to our newer, better option mask property `agnosticOptions` on `FBSnapshotTestCase`.
* Upgrade to recommended settings and use swift 4.2 * Update to latest os image * Run pod install * Add workspace check * Update demo project to 4.2 * Remove Swift 3 objc inference
… fileNameOptions (uber#64)
…s based on the architecture. (uber#87)
…out host application (uber#79)
…or macro to configure the reference image directory (uber#88)
Previously we would compare UIImage size properties, which are not in pixel units but scale-dependent points. This would cause issues if a test used reference images generated using .none fileNameOptions and ran tests on 2x or 3x simulators: they would fail early because of the size comparison because of the scale difference.
This commit changes the logic to use CGImageGet{Width,Height} instead, which returns the actual pixel size (akin to use size * scale) and is backwards compatible since the image comparison code actually uses CGImage pixel retrieving methods.
Added PR uber#100 as the first change that will make it into the next release.
Also tweaked some of the copy so it is up-to-date.
…geWithContentsOfFile" This reverts commit c087b0d.
…e names" This reverts commit dbdbc35.
…swift_library_evolution_support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
This PR looks complex, but it is not. Provided changes:
Breaking changes
,,&,(), etc. in filenames) - check #78. I renamed all the files in our repository (IOS-29155)Future improvements
fileNameOptionsoption to control filenames and device/OS-specific information. Take a look if you are interested.