Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manifold doesn't work with react-redux 6 or above #59

Closed
Firenze11 opened this issue Oct 30, 2019 · 1 comment
Closed

Manifold doesn't work with react-redux 6 or above #59

Firenze11 opened this issue Oct 30, 2019 · 1 comment

Comments

@Firenze11
Copy link
Contributor

Summary

When the app is using react-redux>=6, manifold has issue finding the store instance.
image

Expected Behavior

Manifold should work when the embedded app is using react-redux@6 or above
@Firenze11 Firenze11 mentioned this issue Oct 30, 2019
Merged
3 tasks
Firenze11 added a commit that referenced this issue Oct 30, 2019
@Firenze11
Upgrade to react-redux-7, fix store instance missing issue #59 (#60)
5e5ba36 
* Upgrade react-redux dependency to 7
* react-redux in example and demo app both resolve to root level dependency
* Moved dependency for react-redux in manifold package to peerDependency
@Firenze11
Copy link
Contributor Author

Fixed by #60

@Firenze11 Firenze11 mentioned this issue Nov 7, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Firenze11