Upgrade to react-redux-7, fix store instance missing issue #59 #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In v6 react-redux migrated from legacy react context to
createContext
. And in order forconnect
to access thestore
object passed fromProvider
,connect
andProvider
must come from a single react-redux dependency. Previously manifold depends on react-redux, and the embedded app also depends on react-redux, which results inconnect
andProvider
coming from different places and caused the error in #59react-redux
in example and demo app both resolve to root level dependencyreact-redux
in manifold package to peerDependencyTest Plan
Both example and demo app can render; other app that are using Manifold won't crash (after the change is published)
Checklist
[ ] I have added tests to cover my changes (for features and bug fixes).[ ] I have updated the documentation and changelogs accordingly.