-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo Structure (Using Ocular) #18
Conversation
Looks like the tests failed on eslint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: missing the description
field in feature-list-view
& mlvis-common
.
The description for multi-way-plot
, segment-filters
, etc. are off (currently copied from Manifold's).
Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also change kepler version to 1.1.5. Otherwise LGTM
Using the monorepo structure for the repository (leveraging ocular).
Tested using the website and example folder:
installation steps:
Notes: