Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure ocular to build only esm #56

Merged
merged 6 commits into from
Oct 8, 2019
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/feature-list-view/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"Yang Wang <gnavvy@uber.com>",
"Lezhi Li <lezhi.li@uber.com>"
],
"main": "dist/esm/index.js",
"main": "dist/index.js",
"repository": {
"type": "git",
"url": "git+https://github.com/uber/manifold.git"
Expand Down
2 changes: 1 addition & 1 deletion modules/manifold/actions.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = require('./dist/esm/actions');
module.exports = require('./dist/actions');
2 changes: 1 addition & 1 deletion modules/manifold/index.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = require('./dist/esm');
module.exports = require('./dist');
2 changes: 1 addition & 1 deletion modules/manifold/middleware.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = require('./dist/esm/middleware');
module.exports = require('./dist/middleware');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's only one build, it should be possible to remove these proxy files entirely. Please evaluate the possibility (trying building, publishing and installing if necessary)

2 changes: 1 addition & 1 deletion modules/manifold/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"description": "Model-Agnostic Visual Debugging Tool for Machine Learning",
"license": "Apache-2.0",
"author": "Firenze11 <lezhi.li@uber.com>",
"main": "index.js",
"main": "dist/index.js",
"repository": {
"type": "git",
"url": "git+https://github.com/uber/manifold.git"
Expand Down
2 changes: 1 addition & 1 deletion modules/manifold/reducers.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = require('./dist/esm/reducers');
module.exports = require('./dist/reducers');
2 changes: 1 addition & 1 deletion modules/mlvis-common/constants.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = require('./dist/esm/constants');
module.exports = require('./dist/constants');
2 changes: 1 addition & 1 deletion modules/mlvis-common/icons.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = require('./dist/esm/icons');
module.exports = require('./dist/icons');
2 changes: 1 addition & 1 deletion modules/mlvis-common/index.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = require('./dist/esm');
module.exports = require('./dist');
2 changes: 1 addition & 1 deletion modules/mlvis-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"Lezhi Li <lezhi.li@uber.com>",
"Yang Wang <gnavvy@uber.com>"
],
"main": "dist/esm/index.js",
"main": "dist/index.js",
"repository": {
"type": "git",
"url": "git+https://github.com/uber/manifold.git"
Expand Down
2 changes: 1 addition & 1 deletion modules/mlvis-common/ui.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = require('./dist/esm/ui');
module.exports = require('./dist/ui');
2 changes: 1 addition & 1 deletion modules/mlvis-common/utils.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = require('./dist/esm/utils');
module.exports = require('./dist/utils');
2 changes: 1 addition & 1 deletion modules/multi-way-plot/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"description": "Multi Way Plot component of the Manifold",
"license": "Apache-2.0",
"author": "Firenze11 <lezhi.li@uber.com>",
"main": "dist/esm/index.js",
"main": "dist/index.js",
"repository": {
"type": "git",
"url": "git+https://github.com/uber/manifold.git"
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"private": true,
"author": "Firenze11 <lezhi.li@uber.com>",
"main": "dist/esm/index.js",
"main": "dist/index.js",
"repository": {
"type": "git",
"url": "git+https://github.com/uber/manifold.git"
Expand Down Expand Up @@ -57,7 +57,7 @@
"less-loader": "^5.0.0",
"mini-css-extract-plugin": "^0.7.0",
"node-sass": "^4.11.0",
"ocular-dev-tools": "0.0.27",
"ocular-dev-tools": "0.0.30",
"postcss-loader": "^3.0.0",
"prettier": "^1.18.0",
"prettier-eslint-cli": "^4.7.1",
Expand All @@ -74,8 +74,8 @@
"lint": "eslint modules",
"cover": "jest --coverage --config=jest.config.js",
"test": "jest",
"clean": "ocular-clean",
"build": "ocular-clean && ocular-build && lerna run build",
"clean": "ocular-clean all",
"build": "ocular-clean all && ocular-build --dist esm && lerna run build",
"publish": "ocular-publish",
"-------- LERNA --------": "",
"bump": "npm run lerna:bump",
Expand Down