configure ocular to build only esm #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenns29
commented
Oct 5, 2019
package.json
Outdated
| @@ -97,7 +97,7 @@ | |||
| "traverse": "python scripts/traverse.py" | |||
| }, | |||
| "engines": { | |||
| "node": ">=8.9.4 <9.0.0", | |||
| "node": ">=8.9.4", | |||
There was a problem hiding this comment.
base-ui requires a node engine version greater than v10
gnavvy
approved these changes
Oct 7, 2019
Firenze11
suggested changes
Oct 7, 2019
There was a problem hiding this comment.
Please update these proxy files as well https://github.com/uber/manifold/blob/master/modules/manifold/index.js#L1
Did, can you try remove these files and do test publish to see if it works. |
Firenze11
reviewed
Oct 7, 2019
modules/manifold/middleware.js
Outdated
| @@ -1 +1 @@ | |||
| module.exports = require('./dist/esm/middleware'); | |||
| module.exports = require('./dist/middleware'); | |||
There was a problem hiding this comment.
If there's only one build, it should be possible to remove these proxy files entirely. Please evaluate the possibility (trying building, publishing and installing if necessary)
Firenze11
approved these changes
Oct 8, 2019
Firenze11
added a commit
that referenced
this pull request
Nov 6, 2019
1. Ocular-publish script doesn't work, use lerna publish instead. 2. importing from sub-directories (e,g, `import * from @mlvis/manifold/actions`) still doesn't work despite ocular-build only builds esm version (#56), publish `/dist` folders directly instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Related Issue(s)
Addresses #31
Changes
ocular-clean all && ocular-build --dist esmas the ocular change in tweak build to accept options to build selected targets. uber-web/ocular#251 was published.Test Plan
Do a test build and publish to see if it works.
Checklist
I have added tests to cover my changes (for features and bug fixes).I have updated the documentation and changelogs accordingly.