-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure ocular to build only esm #56
Conversation
package.json
Outdated
@@ -97,7 +97,7 @@ | |||
"traverse": "python scripts/traverse.py" | |||
}, | |||
"engines": { | |||
"node": ">=8.9.4 <9.0.0", | |||
"node": ">=8.9.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
base-ui requires a node engine version greater than v10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update these proxy files as well https://github.com/uber/manifold/blob/master/modules/manifold/index.js#L1
Did, can you try remove these files and do test publish to see if it works. |
modules/manifold/middleware.js
Outdated
@@ -1 +1 @@ | |||
module.exports = require('./dist/esm/middleware'); | |||
module.exports = require('./dist/middleware'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's only one build, it should be possible to remove these proxy files entirely. Please evaluate the possibility (trying building, publishing and installing if necessary)
1. Ocular-publish script doesn't work, use lerna publish instead. 2. importing from sub-directories (e,g, `import * from @mlvis/manifold/actions`) still doesn't work despite ocular-build only builds esm version (#56), publish `/dist` folders directly instead.
Summary | Related Issue(s)
Addresses #31
Changes
ocular-clean all && ocular-build --dist esm
as the ocular change in tweak build to accept options to build selected targets. uber-web/ocular#251 was published.Test Plan
Do a test build and publish to see if it works.
Checklist
I have added tests to cover my changes (for features and bug fixes).I have updated the documentation and changelogs accordingly.