Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the MA causal experimental component inside the Juypter binding #88

Merged
merged 16 commits into from Dec 13, 2019
Merged

Add the MA causal experimental component inside the Juypter binding #88

merged 16 commits into from Dec 13, 2019

Conversation

kenns29
Copy link
Collaborator

@kenns29 kenns29 commented Dec 11, 2019 •
edited

Summary | Related Issue(s)

Add the MA causal experimental component inside the Jupyter binding (#71)

image

Changes

  1. The Jupyter binding now contains a MACausal component
  2. This component is still in an experimental state and is unrelated to the other components inside the repo
  3. The JS part of the component code is located in bindings/jupyter-modules/jupyter-ma-causal
  4. All the changes of this PR have been reviewed separately in the sub-PRs

Checklist

  • I have made this PR atomic.
  • I have provided enough context for others to review.
  • [ ] I have added tests to cover my changes (for features and bug fixes).
  • [ ] I have updated the documentation and changelogs accordingly.
  • All new and existing tests passed.

kenns29 and others added 14 commits November 25, 2019 11:23
@kenns29
Scaffolding MA causal project (#70)
e2854d7 
####  Summary | Related Issue(s)

Scaffolding the MA causal project described in [this issue](#71)

#### Changes

Added the `bindings/jupyter-modules/jupyter-ma-causal` experimental module, allow it to be used inside Jupyter as such

![image](https://user-images.githubusercontent.com/7333962/69565131-2b42c400-0f69-11ea-93d0-f4db7035c46b.png)

The line chart draws the two curves representing different uplift effect, with the x axis being the percentile of users ranked according to their likelihood of being influenced by the treatment, and the y axis being the magnitude of the uplift effect scaled between 0 to 1.

The slider will be able to control the percentile of users and the uplift effect corresponding the percentile will be highlighted accordingly.
@kenns29
use selector pattern to update the slider values (#72)
f5f5bf2
@kenns29
Implement the slider labels (#73)
6a0fb0b
@kenns29
align the padding for each chart in the column to prepare for the glo…
b6f44d5 
…bal line indicator (#74)
@kenns29
Add the indicator line (#75)
ef3c123
@kenns29
Auto adjust width and height (#80)
004b223 
* adjust right padding to make space for the right most label in the x axis

* auto adjust width and height
@kenns29
Add treatment and control bars (#81)
19aaaa7 
* add treatment and control bars

* Addressing the review comments
@kenns29
Add label for the line indicator (#82)
ddc0dab 
* add treatment and control bars

* add label for the line indicator

* Addressing the review comments
@kenns29
Clean up unused vars (#83)
f7c7da8 
* add treatment and control bars

* add label for the line indicator

* clean up unused vars

* Addressing the review comments
@kenns29
remove the scaling hack (#84)
36173fb
@kenns29
Indent the bar labels (#85)
278310d 
* remove the scaling hack

* ma-causal-dev-1
@kenns29
Accepts line data whose y values have scales other than [0, 1] (#86)
aafb42b 
* remove the scaling hack

* ma-causal-dev-1

* split the multi line charts to separate charts

* update slidebar and static bar
@kenns29
Use 2 decimal for the bar labels (#87)
3ca8581 
* remove the scaling hack

* ma-causal-dev-1

* split the multi line charts to separate charts

* update slidebar and static bar

* use 2 decimal for the bar label
@kenns29
merge with master
1fd2955
@kenns29 kenns29 requested a review from gnavvy December 11, 2019 18:43
@kenns29 kenns29 requested a review from mmui December 11, 2019 18:49
@kenns29 kenns29 merged commit b86c31a into master Dec 13, 2019
@kenns29 kenns29 deleted the ma-causal branch December 13, 2019 22:46
@kenns29 kenns29 mentioned this pull request Dec 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnavvy gnavvy gnavvy approved these changes

@mmui mmui Awaiting requested review from mmui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kenns29 @gnavvy