Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unused vars #83

Merged
merged 8 commits into from
Dec 9, 2019
Merged

Clean up unused vars #83

merged 8 commits into from
Dec 9, 2019

Conversation

kenns29
Copy link
Collaborator

@kenns29 kenns29 commented Dec 7, 2019

Summary | Related Issue(s)

Clean up some unused variables.

Test Plan

Checklist

  • I have made this PR atomic.
  • I have provided enough context for others to review.
  • [ ] I have added tests to cover my changes (for features and bug fixes).
  • [ ] I have updated the documentation and changelogs accordingly.
  • All new and existing tests passed.

@kenns29 kenns29 added the refactoring Code architecture needs to change label Dec 7, 2019
@kenns29 kenns29 requested a review from gnavvy December 7, 2019 03:48
@kenns29 kenns29 changed the base branch from ma-causal-dev-1 to ma-causal December 9, 2019 22:26
@kenns29 kenns29 merged commit f7c7da8 into ma-causal Dec 9, 2019
@kenns29 kenns29 deleted the ma-causal-dev-2 branch December 9, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javidhsueh javidhsueh javidhsueh approved these changes

@gnavvy gnavvy Awaiting requested review from gnavvy

Assignees
No one assigned
Labels
refactoring Code architecture needs to change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kenns29 @javidhsueh