Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign key prop to html-overlay children that don't already have one specified #348

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Assign key prop to html-overlay children that don't already have one specified #348

merged 1 commit into from
Mar 11, 2020

Conversation

dmaskasky
Copy link
Contributor

No description provided.

@dmaskasky dmaskasky self-assigned this Mar 11, 2020
@dmaskasky dmaskasky added the bug Something isn't working label Mar 11, 2020
@dmaskasky dmaskasky added this to the Nebula 1.0.0 milestone Mar 11, 2020
@CLAassistant
Copy link

CLAassistant commented Mar 11, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1688

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 29.675%
Totals Coverage Status
Change from base Build 1686: 0.05%
Covered Lines: 1061
Relevant Lines: 3444
💛 - Coveralls

@georgios-uber georgios-uber merged commit a94e77d into master Mar 11, 2020
@georgios-uber georgios-uber deleted the htmlOverlayKeyProp branch March 11, 2020 01:19
austintang pushed a commit to austintang/nebula.gl that referenced this pull request Mar 12, 2020
@dmaskasky @austintang
Assign key prop to html-overlay children that don't already have one …
a54c530 
…specified (uber#348)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgios-uber georgios-uber georgios-uber approved these changes

Assignees

@dmaskasky dmaskasky

Labels
bug Something isn't working
Projects
None yet
Milestone
Nebula 1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dmaskasky @CLAassistant @coveralls @georgios-uber