Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on OSX with clang 11 reports warnings #224

Closed
vkuzmin-uber opened this issue Nov 19, 2019 · 0 comments · Fixed by #225
Closed

Build on OSX with clang 11 reports warnings #224

vkuzmin-uber opened this issue Nov 19, 2019 · 0 comments · Fixed by #225

Comments

@vkuzmin-uber
Copy link
Contributor

vkuzmin-uber commented Nov 19, 2019

Two warnings during build on OSX with clang

g++ --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/c++/4.2.1
Apple clang version 11.0.0 (clang-1100.0.33.12)
Target: x86_64-apple-darwin18.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

1st:

INFO: From Compiling neuropods/multiprocess/multiprocess.cc:
neuropods/multiprocess/multiprocess.cc:37:9: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings]
        "neuropod_multiprocess_worker",

here explicit cast helps

2nd:

INFO: From Compiling neuropods/multiprocess/ipc_control_channel.cc:
In file included from neuropods/multiprocess/ipc_control_channel.cc:10:
./neuropods/multiprocess/shm_tensor.hh:39:7: warning: unused function 'get_next_aligned_offset' [-Wunused-function]
void *get_next_aligned_offset(void *base)

Compiler warning is not correct, function is used. Function is defined in header and making it "inline" fixes warning and is reasonable at the same time.

I can provide pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant