OkBuck generates incorrect Buck file with test artifact

[cwoodwar6]

Dependencies.gradle:

ext.deps = [
    dagger2: [
        dagger2: "com.google.dagger:dagger:2.8",
        dagger2compiler: "com.google.dagger:dagger-compiler:2.8",
        dagger2Test: "com.google.dagger:dagger:2.8:tests"
    ]
]

App module dependencies:

  compile project(':app-library')

  compile deps.dagger2.dagger2
  annotationProcessor deps.dagger2.dagger2compiler
  testCompile deps.dagger2.dagger2Test

Library module dependencies:

  compile deps.dagger2.dagger2
  annotationProcessor deps.dagger2.dagger2compiler

The library module's generated Buck file:

deps = [
   '//.okbuck/cache:com.google.dagger.dagger-2.8-tests.jar',
]

Dagger's test artifact is used in the library module instead of the main dagger artifact.

This line:
//.okbuck/cache:com.google.dagger.dagger-2.8-tests.jar
should instead be:
//.okbuck/cache:com.google.dagger.dagger-2.8.jar

Repro project: https://github.com/cwoodwar6/okbuck-test-project

[kageiit]

I think this is because the dependency cache does not handle artifacts with classifiers correctly yet.

cc @raviagarwal7

We will work on a fix, but in the meanwhile, you can try to rename your artifact to something like com.google.dagger:dagger-tests:2.8 and upload to a local maven. The other option is to consume the dagger test jar as a local jar dependency to unblock yourself.

[hanjunx]

lgtm Hanjun

…

On Wed, Feb 1, 2017 at 8:06 AM, Gautam Korlam ***@***.***> wrote: I think this is because the dependency cache does not handle artifacts with classifiers correctly yet. cc @raviagarwal7 <https://github.com/raviagarwal7> We will work on a fix, but in the meanwhile, you can try to rename your artifact to something like com.google.dagger:dagger-tests:2.8 and upload to a local maven. The other option is to consume the dagger test jar as a local jar dependency to unblock yourself. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#375 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACW3y-5vA4CxG_MhSv7XFmKL_LwSdVBwks5rX8yPgaJpZM4LzJIy> .