Add support for classifiers in external dependencies #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kageiit
commented
Feb 9, 2017
kageiit
commented
- Fixes OkBuck generates incorrect Buck file with test artifact #375
Two reasons why the default needs to be “debug”: 1.) If the default is null, ProjectDependency will resolve to a different cache entry than its AAR ExternalDependency. 2.) On subsequent runs of the OkBuck task, the cache has been populated and all artifacts have a null classifier. This would cause conflict with those that had classifiers originally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.