-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch standard way of publishing to maven + prepare to publish V0.52.4 #950
Conversation
buildSrc/gradle.properties
Outdated
@@ -0,0 +1,16 @@ | |||
GROUP=com.uber | |||
VERSION_NAME=0.52.4 | |||
POM_DESCRIPTION=AGradle plugin that lets developers utilize the Buck build system on a Gradle project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo - "A Gradle"
@@ -41,6 +41,8 @@ def okbuck_android_module( | |||
res_assets = None, | |||
res_resource_union = None, | |||
res_extra_deps = [], | |||
res_deps = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you undo these changes or move them to a separate PR please?
sign configurations.archives | ||
} | ||
|
||
if (project.getPlugins().hasPlugin('com.android.application') || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably dont want to publish the example projects so please make sure to mark those as not publishable. We only want to publish the plugin
project
Switch standard way of publishing to maven + prepare to publish V0.52.4