Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit dlt #63

Merged
merged 8 commits into from
Mar 31, 2020
Merged

Revisit dlt #63

merged 8 commits into from
Mar 31, 2020

Conversation

edwinnglabs
Copy link
Collaborator

@edwinnglabs edwinnglabs commented Mar 29, 2020 •
edited
Loading

#62 and part of #58

steveyang90
steveyang90 requested changes Mar 30, 2020
View reviewed changes
Copy link
Collaborator

@steveyang90 steveyang90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to inline a few other notes:

  • can you also confirm that changes to examples/DLT_Example.ipynb are intentional.
  • orbit.Rproj accidental commit?

orbit/dlt.py Outdated Show resolved Hide resolved
orbit/dlt.py Outdated Show resolved Hide resolved
orbit/dlt.py Outdated Show resolved Hide resolved
orbit/constants/dlt.py Outdated Show resolved Hide resolved
orbit/dlt.py Outdated Show resolved Hide resolved
orbit/estimator.py Show resolved Hide resolved
orbit/lgt.py Show resolved Hide resolved
orbit.Rproj Outdated Show resolved Hide resolved
@edwinnglabs
Copy link
Collaborator Author

edwinnglabs commented Mar 30, 2020 •
edited
Loading

In addition to inline a few other notes:

  • can you also confirm that changes to examples/DLT_Example.ipynb are intentional.
  • orbit.Rproj accidental commit?

definitely not .Rproj. Let me remove it and probably .Rproj should sit in ignore always.
the change for examples/DLT_Example.ipynb is intentional tho

steveyang90
steveyang90 reviewed Mar 31, 2020
View reviewed changes
Copy link
Collaborator

@steveyang90 steveyang90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edwinnglabs second pass of review, feel free to merge after

orbit/lgt.py Show resolved Hide resolved
orbit/lgt.py Outdated Show resolved Hide resolved
orbit/dlt.py Outdated Show resolved Hide resolved
orbit/dlt.py Outdated Show resolved Hide resolved
steveyang90
steveyang90 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Collaborator

@steveyang90 steveyang90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edwinnglabs edwinnglabs merged commit 3cd1857 into master Mar 31, 2020
@edwinnglabs edwinnglabs deleted the revisit-dlt branch May 2, 2020 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveyang90 steveyang90 steveyang90 approved these changes

@wangzhishi wangzhishi Awaiting requested review from wangzhishi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwinnglabs @steveyang90