Never consider httplib timeout safe

[eskil]

It just isn't since the timeout is only used for connection.

http://www.gossamer-threads.com/lists/python/dev/840163
http://hg.python.org/cpython/file/2.7/Lib/httplib.py

[eskil]

15:09:36 eskil ~/src/github/eskil/py-look-for-timeouts (master)$ python -m py_look_for_timeouts.main tests/samples/*
tests/samples/bad_httpconnection.py:4   httplib is never timeout safe
tests/samples/bad_httpconnection.py:5   httplib is never timeout safe
tests/samples/bad_httpconnection.py:6   httplib is never timeout safe
tests/samples/bad_httpconnection.py:7   httplib is never timeout safe
tests/samples/bad_httpconnection.py:8   httplib is never timeout safe
tests/samples/bad_httpconnection.py:9   httplib is never timeout safe
tests/samples/bad_requests.py:3 requests call without a timeout arg or kwarg
tests/samples/bad_requests.py:4 requests call with a timeout kwarg of 0
tests/samples/bad_requests.py:5 requests call without a timeout arg or kwarg
tests/samples/bad_requests.py:6 requests call without a timeout arg or kwarg
tests/samples/bad_requests.py:7 requests call with a timeout kwarg of 0
tests/samples/bad_script.py:3   urlopen call without a timeout arg or kwarg
tests/samples/bad_script.py:4   urlopen call with a timeout kwarg of 0
tests/samples/bad_script.py:6   urlopen call with a timeout arg of 0
tests/samples/bad_script_2.py:3 urlopen call without a timeout arg or kwarg
tests/samples/bad_script_2.py:4 urlopen call with a timeout kwarg of 0
tests/samples/bad_script_2.py:6 urlopen call with a timeout arg of 0
tests/samples/bad_twilio_connection.py:4    twilio rest connection without a timeout arg or kwarg
tests/samples/bad_twilio_connection.py:5    twilio rest connection without a timeout arg or kwarg
tests/samples/bad_twilio_connection.py:6    twilio rest connection with a timeout kwarg of 0
tests/samples/bad_twilio_connection.py:7    twilio rest connection without a timeout arg or kwarg
tests/samples/bad_twilio_connection.py:8    twilio rest connection without a timeout arg or kwarg
tests/samples/bad_twilio_connection.py:9    twilio rest connection with a timeout arg of 0
tests/samples/good.py:15    httplib is never timeout safe
tests/samples/good.py:16    httplib is never timeout safe

[eskil]

bmup

[eskil]

n/m me. I could've sworn we repeatedly had the problem described above at yelp.

[Roguelazer]

That was with Python 2.5.