Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding false to allowed values for animation property #163

Closed
wants to merge 1 commit into from

Conversation

jameskraus
Copy link

Related issue: #162

@chrisirhc
Copy link
Contributor

Thanks for your contribution, @jameskraus !
Before I merge in your changes, I need you to sign our Uber Contributor License Agreement: http://t.uber.com/cla
Could you please do that and then post a comment here when that's done?

@jameskraus
Copy link
Author

jameskraus commented Nov 10, 2016

I can't sign any CLAs. If you wanted to make a similar, yet unique change to the code, then I guess that would work. It just so happens that there is a built in proptype that does the exact same thing as oneOf([true, false]), so anyone else could make that commit.

balthazar pushed a commit that referenced this pull request Nov 11, 2016
ayarcohaila pushed a commit to ayarcohaila/react-vis that referenced this pull request Jun 30, 2021
ayarcohaila added a commit to ayarcohaila/react-vis that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants