tickSizeInner should be tickSizeOuter and vice versa. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reference point. The old version had it inverted. Updated the complex-chart example to show that the changes work.
src/styles/examples.scss
Outdated
| @@ -158,6 +158,9 @@ article { | |||
|
|
|||
| .chart { | |||
| margin-right: 200px; | |||
| & .rv-xy-plot__axis__tick__line { | |||
| stroke: #6b6b76; | |||
There was a problem hiding this comment.
nits:
- i dont think you need the &
- can you use a scss variable instead for the hex value?
mcnuttandrew
approved these changes
Feb 20, 2017
|
Can you also add some notes in the docs about this? |
balthazar
reviewed
Feb 20, 2017
| <XAxis className="even-cooler-custom-name"/> | ||
| <YAxis | ||
| className="cool-custom-name" | ||
| tickSizeInner={ 0 } |
There was a problem hiding this comment.
Could you please remove the spacing between the brackets?
There was a problem hiding this comment.
too late. You don't like the clarity this gives?
There was a problem hiding this comment.
Fixed on master. Consistency is my issue
…d tickSizeOuter applies to.
mcnuttandrew
pushed a commit
to mcnuttandrew/react-vis
that referenced
this pull request
Feb 20, 2017
* tickSizeInner should be tickSizeOuter and vice versa. The plot is the reference point. The old version had it inverted. Updated the complex-chart example to show that the changes work. * Address Andrew's comments - use existing scss variable for line color. * Update docs/xy-plot.md indicating correction of what tickSizeInner and tickSizeOuter applies to.
mcnuttandrew
pushed a commit
to mcnuttandrew/react-vis
that referenced
this pull request
Mar 20, 2017
* tickSizeInner should be tickSizeOuter and vice versa. The plot is the reference point. The old version had it inverted. Updated the complex-chart example to show that the changes work. * Address Andrew's comments - use existing scss variable for line color. * Update docs/xy-plot.md indicating correction of what tickSizeInner and tickSizeOuter applies to.
ayarcohaila
pushed a commit
to ayarcohaila/react-vis
that referenced
this pull request
Jun 30, 2021
* tickSizeInner should be tickSizeOuter and vice versa. The plot is the reference point. The old version had it inverted. Updated the complex-chart example to show that the changes work. * Address Andrew's comments - use existing scss variable for line color. * Update docs/xy-plot.md indicating correction of what tickSizeInner and tickSizeOuter applies to.
ayarcohaila
added a commit
to ayarcohaila/react-vis
that referenced
this pull request
May 30, 2023
* tickSizeInner should be tickSizeOuter and vice versa. The plot is the reference point. The old version had it inverted. Updated the complex-chart example to show that the changes work. * Address Andrew's comments - use existing scss variable for line color. * Update docs/xy-plot.md indicating correction of what tickSizeInner and tickSizeOuter applies to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plot is the reference point. The old version had it inverted.
Updated the complex-chart example to show that the changes work.
Attached image shows the example with outTicks of size 8.