Performance: only add one resize listener with makeVisFlexible #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| function remove(list, item) { |
There was a problem hiding this comment.
Is there a helper/pattern already in the codebase for removing from an array?
btford
force-pushed
the
perf-resize-event-subscriptions
branch
from
58a5404
to
7922055
Compare
| } | ||
| } | ||
|
|
||
| function remove(list, item) { |
There was a problem hiding this comment.
Could you rename remove to something more specific? e.g. removeListener?
btford
force-pushed
the
perf-resize-event-subscriptions
branch
from
7922055
to
dd476db
Compare
| // if we have no Flexible components, remove the listener | ||
| if (resizeSubscribers.length == 0) { | ||
| window.clearTimeout(timeoutId); | ||
| window.removeEventListener('resize', emit); |
There was a problem hiding this comment.
This should be debounceEmitResize
|
@btford , I highly suggest to add descriptions for the functions that you have. JSDoc is not enforced in this project, but can be a good option. |
|
@bulyonov Done. |
btford
force-pushed
the
perf-resize-event-subscriptions
branch
from
dd476db
to
fbdf582
Compare
ayarcohaila
pushed a commit
to ayarcohaila/react-vis
that referenced
this pull request
Jun 30, 2021
Performance: only add one resize listener with makeVisFlexible
ayarcohaila
added a commit
to ayarcohaila/react-vis
that referenced
this pull request
May 30, 2023
Performance: only add one resize listener with makeVisFlexible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a somewhat un-scientific test on my local machine, I saw a 50% reduction in latency when you have 4-5 flexible components.
I think we should discuss this a bit before merging, but here's the basic idea:
Rather than have each instance add an event listener to the window, we consolidate the subscripting into a global queue. This also means that we only have one debounce-er for the event as well.
The same idea should be applicable to anywhere that a component uses
componentDidMountandcomponentWillUnmountto add event listeners.The current implementation introduces a couple extra helpers. I think we can simplify this since
react-visonly needs this pattern in one place.Another note: this change removes the possibility for setting the debounce for resize on a per-component basis. I personally think that this is silly– reacting to the resize multiple times due to a difference in debounce rate would likely degrade performance.
The current PR makes the debounce fixed at 100ms. I'm not sure what the best way to expose a global debounce setting would be. Are there any other such global settings in react-vis?