Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with example for forwarded pings. #14

Merged
merged 1 commit into from
Oct 6, 2015

Conversation

thanodnl
Copy link
Contributor

@thanodnl thanodnl commented Oct 5, 2015

Pings that should be forwarded where causing timeouts. When waiting long enough it responded with a JSON parse error.

Cause was 0x0000 in the header of the forwarded request which was not parseable.

@jwolski
Copy link
Contributor

jwolski commented Oct 5, 2015

lgtm. self-merge when ready

thanodnl added a commit that referenced this pull request Oct 6, 2015
Fix issue with example for forwarded pings.
@thanodnl thanodnl merged commit e29bc2f into master Oct 6, 2015
@thanodnl thanodnl deleted the fix-example-ping-ring branch October 6, 2015 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants