Fix: Race conditions #178
Merged
Fix: Race conditions #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
August 24, 2016 15:51
…rted Member methode on Node
…ventEmitter in applicable structs
| @@ -28,9 +28,6 @@ env: | |||
| - RUN="make test-examples" | |||
|
|
|||
| matrix: | |||
| allow_failures: | |||
|
Looks really good overall. Some small questions and nits. |
added 3 commits
September 5, 2016 16:24
thanodnl
force-pushed
the
fix/travis-races-manditory
branch
from
a2b640f
to
ded6b51
Compare
added 7 commits
September 6, 2016 14:20
…e to prevent race conditions
thanodnl
force-pushed
the
fix/travis-races-manditory
branch
from
909bf5e
to
4290475
Compare
…ingpop for the time being to help easy upgrading.
thanodnl
force-pushed
the
fix/travis-races-manditory
branch
from
4290475
to
cc23f0c
Compare
| @@ -24,6 +24,8 @@ import ( | |||
| "sort" | |||
| "testing" | |||
|
|
|||
| "github.com/benbjohnson/clock" | |||
|
|
|||
| return stop, wait | ||
| } | ||
|
|
||
| // TODO add schedule once with a quit channel to cancel it for use in the update rollup |
|
There are some todo's left, but besides that: LGTM! |
| @@ -27,9 +27,6 @@ env: | |||
| - RUN="make test-race" | |||
|
|
|||
| matrix: | |||
| allow_failures: | |||
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to remove the races from ringpop-go and let travis actually fail when there are race conditions in ringpop.