Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Race conditions #178

Merged
merged 46 commits into from
Sep 14, 2016
Merged

Fix: Race conditions #178

merged 46 commits into from
Sep 14, 2016

Commits on Aug 24, 2016

  1. Lets fail CI without races passing

    Nils Dijk committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    dbd8c4d View commit details
    Browse the repository at this point in the history

  2. do not return the pointer of the internal Member object from the Expo… 

    …rted Member methode on Node
    Nils Dijk committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    e03924b View commit details
    Browse the repository at this point in the history

  3. fix races around stats measurement

    Nils Dijk committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    ae118a7 View commit details
    Browse the repository at this point in the history

  4. Extract all event emitting logic to the events package and embed an E… 

    …ventEmitter in applicable structs
    Nils Dijk committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    4ed3e46 View commit details
    Browse the repository at this point in the history

  5. Update mocks

    Nils Dijk committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    f56c165 View commit details
    Browse the repository at this point in the history

  6. Fix flappy forwarding test during race detector

    Nils Dijk committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    5f005f0 View commit details
    Browse the repository at this point in the history

  7. Fix race on writing clock.

    Nils Dijk committed Aug 24, 2016
    Configuration menu
    Copy the full SHA
    d60ef61 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2016

  1. copy member instead of passing internal pointer around for MemberAt

    Nils Dijk committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    7a3ea4b View commit details
    Browse the repository at this point in the history

  2. ignore test for now, has 3 races, needs review what is being tested

    Nils Dijk committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    387263b View commit details
    Browse the repository at this point in the history

  3. replace timebased deadline with count based deadline in waitForPartit… 

    …ionHeal
    Nils Dijk committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    468bc6e View commit details
    Browse the repository at this point in the history

  4. fix two flappy tests due to incarnation number mismatches

    Nils Dijk committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    5eac990 View commit details
    Browse the repository at this point in the history

  5. reset the logger to nil (NoLogger) after every test

    Nils Dijk committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    1a7e897 View commit details
    Browse the repository at this point in the history

  6. set timeout to negative value to always time out.

    Nils Dijk committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    427dabf View commit details
    Browse the repository at this point in the history

  7. solve race when sending the membership as changes

    Nils Dijk committed Aug 25, 2016
    Configuration menu
    Copy the full SHA
    0cb966c View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2016

  1. Fix race in RandomPingableMembers

    Nils Dijk committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    068da29 View commit details
    Browse the repository at this point in the history

  2. Fix TestFilterChangesFromSender due to wrong use of incarnation causi… 

    …ng race
    Nils Dijk committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    6600944 View commit details
    Browse the repository at this point in the history

  3. add tests for event registrar and emitter.

    Nils Dijk committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    25018d7 View commit details
    Browse the repository at this point in the history

  4. rework ListenerFunc to be a struct

    Nils Dijk committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    74d94ac View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2016

  1. refactor waitForConvergence to limit number of iterations instead of … 

    …time.
    Nils Dijk committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    8a412a4 View commit details
    Browse the repository at this point in the history

  2. rename utils file for tests to exclude it from compiling

    Nils Dijk committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    3f0dacf View commit details
    Browse the repository at this point in the history

  3. upgrade tchannel-go version

    Nils Dijk committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    bdb3f36 View commit details
    Browse the repository at this point in the history

  4. move ListenerFunc to _test.go file to exclude form export

    Nils Dijk committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    e5872fe View commit details
    Browse the repository at this point in the history

  5. Rephrase documentation for DeregisterListener to be better understand… 

    …able.
    Nils Dijk committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    6f24325 View commit details
    Browse the repository at this point in the history

  6. reserve capacity before copying old listeners

    Nils Dijk committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    3f2e6ae View commit details
    Browse the repository at this point in the history

  7. initialize listeners list with correct size on DeregisterListener

    Nils Dijk committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    3fb3f5c View commit details
    Browse the repository at this point in the history

  8. explain why events.EventRegistar is not embedded in the ringpop inter… 

    …face.
    Nils Dijk committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    83793a6 View commit details
    Browse the repository at this point in the history

  9. Correct naming of Emitter in favor of Registar

    Nils Dijk committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    4e22f77 View commit details
    Browse the repository at this point in the history

  10. Use readlock when reading dummyStats value

    Nils Dijk committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    cf44096 View commit details
    Browse the repository at this point in the history

  11. move test utilities to _test.go file to exclude them from the public … 

    …interface
    Nils Dijk committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    e786039 View commit details
    Browse the repository at this point in the history

  12. Enable last test without race conditions.

    Nils Dijk committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    97e664d View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2016

  1. Remove race causing flappy test when validating events are propagated.

    Nils Dijk committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    e4a0294 View commit details
    Browse the repository at this point in the history

  2. Remove unused dummy listener

    Nils Dijk committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    4dc5867 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2016

  1. rework the background execution of the protocol period to guarantee n… 

    …on double execution.
    Nils Dijk committed Sep 5, 2016
    Configuration menu
    Copy the full SHA
    9193a23 View commit details
    Browse the repository at this point in the history

  2. calculate delay before invocation of background task to mimic old beh… 

    …avior
    Nils Dijk committed Sep 5, 2016
    Configuration menu
    Copy the full SHA
    f1b7c45 View commit details
    Browse the repository at this point in the history

  3. Add todo's for schedule functions to prevent race in update rollup

    Nils Dijk committed Sep 5, 2016
    Configuration menu
    Copy the full SHA
    ded6b51 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2016

  1. Experimental: remove unused update rollup because of raceconditions i… 

    …n there.
    Nils Dijk committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    42bce9b View commit details
    Browse the repository at this point in the history

  2. during stop of gossip wait for the goroutine to be finished

    Nils Dijk committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    ea77981 View commit details
    Browse the repository at this point in the history

  3. fix flappy TestJoinHandlerNotMakingAlive

    Nils Dijk committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    860deaf View commit details
    Browse the repository at this point in the history

  4. For handlers test use a time independant version of WaitForConvergenc… 

    …e to prevent race conditions
    Nils Dijk committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    e57daf8 View commit details
    Browse the repository at this point in the history

  5. Make wait for convergence thread safe by stop the gossips while conve… 

    …rging
    Nils Dijk committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    d242492 View commit details
    Browse the repository at this point in the history

  6. only run coveralls after the unit test.

    Nils Dijk committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    782f8a7 View commit details
    Browse the repository at this point in the history

  7. reduce overall matrix size on travis.

    Nils Dijk committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    1b7470f View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2016

  1. Rename RegisterListener to AddListener, RegisterListener is kept on r… 

    …ingpop for the time being to help easy upgrading.
    Nils Dijk committed Sep 7, 2016
    Configuration menu
    Copy the full SHA
    cc23f0c View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2016

  1. Merge remote-tracking branch 'origin/dev' into fix/travis-races-mandi… 

    …tory
    Nils Dijk committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    fad05e2 View commit details
    Browse the repository at this point in the history

  2. do not execute heal right after bootstrap

    Nils Dijk committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    bc19d8a View commit details
    Browse the repository at this point in the history

  3. cleanup of code

    Nils Dijk committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    dcc3b97 View commit details
    Browse the repository at this point in the history