This repository has been archived by the owner on May 3, 2022. It is now read-only.
Most close ephemeral peers or leak peer objects #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var peer = self.channel.peers.get(self.socketRemoteAddr); | ||
| if (peer) { | ||
| peer.close(noop); | ||
| } |
There was a problem hiding this comment.
This is great and fits our immediate need, but you might be able to knock a non-ephemeral peer out by issuing an ephemeral request from it.
|
🆗 |
|
lgtm |
Raynos
added a commit
that referenced
this pull request
Jul 1, 2015
Most close ephemeral peers or leak peer objects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were leaking peer objects in prod; peer objects will
report stats in a loop. Because we 10s of thousands of
these objects we were reporting the same stat 10s of
thousands of time and saw a huge spike in about 5k
UDP writes per second.
r: @rf @jcorbin @kriskowal