Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log unexpected tchannel system error #101

Merged
merged 2 commits into from
May 20, 2017
Merged

Log unexpected tchannel system error #101

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e0f987
Log unexpected tchannel system error
May 18, 2017
97f3777
Log servcie and method for system error
May 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions runtime/tchannel_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,9 @@ func (s *TChannelRouter) handle(ctx context.Context, handler handler, service st
if er := reader.Close(); er != nil {
return errors.Wrapf(er, "could not close arg3reader for inbound call: %s::%s", service, method)
}
s.logger.Warn("Unexpected tchannel system error",
zap.String("error", err.Error()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should log the thrift service and the thrift method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

)
return call.Response().SendSystemError(err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not want to send the err out. We want to send a generic "Server Error" message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}

Expand Down