-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log unexpected tchannel system error #101
Conversation
runtime/tchannel_server.go
Outdated
@@ -177,6 +177,9 @@ func (s *TChannelRouter) handle(ctx context.Context, handler handler, service st | |||
if er := reader.Close(); er != nil { | |||
return errors.Wrapf(er, "could not close arg3reader for inbound call: %s::%s", service, method) | |||
} | |||
s.logger.Warn("Unexpected tchannel system error", | |||
zap.String("error", err.Error()), | |||
) | |||
return call.Response().SendSystemError(err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not want to send the err
out. We want to send a generic "Server Error" message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
runtime/tchannel_server.go
Outdated
@@ -177,6 +177,9 @@ func (s *TChannelRouter) handle(ctx context.Context, handler handler, service st | |||
if er := reader.Close(); er != nil { | |||
return errors.Wrapf(er, "could not close arg3reader for inbound call: %s::%s", service, method) | |||
} | |||
s.logger.Warn("Unexpected tchannel system error", | |||
zap.String("error", err.Error()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should log the thrift service and the thrift method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
No description provided.