handle headers and params correctly #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- params are getting reordered between check-generate because we are iterating over a map which doesn't gaurantee ordering. Using a list of keys to preserve iteration order fixes that - non-top level headers generate completely meaningless code by having a series of empty if checks and the actual logic that is supposed to gated by the checks are actually generated outside of the if check.
rpatali
commented
Mar 4, 2020
| @@ -448,6 +448,12 @@ func (c *barClient) ArgWithHeaders( | |||
| headers["x-uuid"] = string(*r.UserUUID) | |||
| } | |||
|
|
|||
| if r.ParamsStruct != nil { | |||
There was a problem hiding this comment.
before the fix, this would have been generated as:
if r.ParamsStruct != nil {
if r.ParamsStruct.UserID != nil {
}
}
headers["user-id"] = string(*r.ParamsStruct.UserID)
tejaswiagarwal
approved these changes
Mar 4, 2020
| @@ -552,17 +553,18 @@ func findStructs( | |||
| } | |||
|
|
|||
| seenStructs[longFieldName] = typeName | |||
| itrOrder = append(itrOrder, longFieldName) | |||
There was a problem hiding this comment.
Can you add a comment on why we are doing this? i.e. Ordering problems with maps.
There was a problem hiding this comment.
does it really need a comment? The var is already itrOrder :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iterating over a map which doesn't gaurantee ordering. Using a list of
keys to preserve iteration order fixes that
series of empty if checks and the actual logic that is supposed to gated
by the checks are actually generated outside of the if check.