Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle headers and params correctly #688

Merged
merged 1 commit into from Mar 4, 2020
Merged

handle headers and params correctly #688

merged 1 commit into from Mar 4, 2020

Commits on Mar 4, 2020

  1. handle headers and params correctly 

    - params are getting reordered between check-generate because we are
iterating over a map which doesn't gaurantee ordering. Using a list of
keys to preserve iteration order fixes that
- non-top level headers generate completely meaningless code by having a
series of empty if checks and the actual logic that is supposed to gated
by the checks are actually generated outside of the if check.
    @rpatali
    rpatali committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    ad039b3 View commit details
    Browse the repository at this point in the history