Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when connecting without network enabled on device #20

Closed
flashcode opened this issue May 27, 2012 · 2 comments
Closed

Crash when connecting without network enabled on device #20

flashcode opened this issue May 27, 2012 · 2 comments
Labels
bug

Comments

@flashcode
Copy link
Contributor

If network is not enabled on device (wifi off), when I try to connect, the application crashes.

OS: Android 2.2
Reproductible: always.

Steps:

  1. turn wifi off (and all other data connections)
  2. run weechat, setup relay host/port/passord
  3. connect
    => crash
ubergeek42 added a commit that referenced this issue May 30, 2012
@ubergeek42
Fix null pointer exceptions
c59a978 
Check that the relay service binder isn't null before trying to do
things with it.  This maybe fixes issue #20.
@ubergeek42
Copy link
Owner

Also see commit: 16afa1d

Thanks for the bug report. I believe I was able to reproduce the issue you were encountering(along with some other bugs). I've fixed what I was able to find, and built a new apk with the fixes:
http://repository-ubergeek42.forge.cloudbees.com/release/weechat-16afa1d.apk

I'm going to close this issue, but if it still crashes feel free to reopen it(or open a new one if it won't let you).

@flashcode
Copy link
Contributor Author

Works fine, no more crash. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ubergeek42 @flashcode