HDF5 specification #156
Merged
HDF5 specification #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests will presumably fail until ubermag/discretisedfield#377 is merged. |
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
=======================================
Coverage 36.36% 36.36%
=======================================
Files 2 2
Lines 22 22
=======================================
Hits 8 8
Misses 14 14 ☔ View full report in Codecov by Sentry. |
samjrholt
reviewed
Sep 22, 2023
There was a problem hiding this comment.
Looks very good and informative, only a few things. One possible thing about the general structure was should talking about the attributes maybe be moved to after the tree? Then we explain basically everything in a single markdown cell rather than having a short break. Just an idea - I don't really mind :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This notebooks describes and demonstrates the functionality of the extended HDF5 file format used in
discretisedfield. The specification of Fields is intended to be general enough so that an extension of this document can also define a format for an HDF5 file that contains more data, e.g. a wholedriveinside a single file, while re-using the specification (and implementation) ofdiscretisedfield.