-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDF5 specification #156
HDF5 specification #156
Conversation
Tests will presumably fail until ubermag/discretisedfield#377 is merged. |
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
=======================================
Coverage 36.36% 36.36%
=======================================
Files 2 2
Lines 22 22
=======================================
Hits 8 8
Misses 14 14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good and informative, only a few things. One possible thing about the general structure was should talking about the attributes maybe be moved to after the tree? Then we explain basically everything in a single markdown cell rather than having a short break. Just an idea - I don't really mind :)
This notebooks describes and demonstrates the functionality of the extended HDF5 file format used in
discretisedfield
. The specification of Fields is intended to be general enough so that an extension of this document can also define a format for an HDF5 file that contains more data, e.g. a wholedrive
inside a single file, while re-using the specification (and implementation) ofdiscretisedfield
.