Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty significant changes for a small app that were inevitably coming #77

Merged
merged 1 commit into from Jan 21, 2019
Merged

Pretty significant changes for a small app that were inevitably coming #77

merged 1 commit into from Jan 21, 2019

Conversation

TacoTheDank
Copy link
Contributor

@TacoTheDank TacoTheDank commented Jan 14, 2019

  • After endlessly fighting with the project and constantly moving the assets folder around trying to get Gradle to notice it, I decided to just revert back to the old configuration (which isn't a bad thing, just a little weird).
  • Updated 'de.cketti.library.changelog:ckchangelog:1.2.2' to 'de.cketti.library.changelog:ckchangelog-legacy-dialog:2.0.0-SNAPSHOT' (contained breaking changes (you'll likely notice what they are, but feel free to ask if you don't))
  • Migrated App to AppCompat
  • Migrated to AndroidX
  • Bumped version from 2.1 to 3.0, as they're pretty significant if you ask me 2.2

@TacoTheDank
Copy link
Contributor Author

TacoTheDank commented Jan 14, 2019

Also you'll need to start uploading new versions to the Google Play Store; it's still on 2.08 (from 2016).

@TacoTheDank
Copy link
Contributor Author

UPDATE: DO NOT MERGE YET. Testing the apks I built, any apks built after migration of app to appcompat crash at startup.

@uberspot
Copy link
Owner

Ok will do, once you fix it I can merge/test/update Play store. I'll do all at the same time 👍 Nice work btw.

Signed-off-by: Taco <SkytkRSfan3895@gmail.com>
@TacoTheDank
Copy link
Contributor Author

TacoTheDank commented Jan 17, 2019

Alright. This is the most that can be done. I initially thought the crashing might've been an issue with adding a call on super on the save instance state for the AppCompat library migration, but it's apparently not (as I tried lint disabling and built apks still crashed (it wasn't a code error, just a lint error)). App version will just go from 2.1 -> 2.2.

Everything is good to go.

@TacoTheDank
Copy link
Contributor Author

TacoTheDank commented Jan 17, 2019

Also I found a shitty ad-ridden ripoff of this 2048 port, didn't even change the description: https://play.google.com/store/apps/details?id=com.uberspot.amrmustafa

god I hate people that do this

@uberspot uberspot merged commit d3975d9 into uberspot:master Jan 21, 2019
@uberspot
Copy link
Owner

Tested locally and it seems to work fine now. Merged, tagged "v2.2" on git and I pushed an updated apk to play store too. 👍 Nice work.

@TacoTheDank
Copy link
Contributor Author

:P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants